Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix background colours in nested submenus. #36476

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Fix background colours in nested submenus. #36476

merged 1 commit into from
Nov 17, 2021

Conversation

tellthemachines
Copy link
Contributor

Description

Fixes #36427 and #36439.

The background colour classnames weren't rendering on the front end due to a attribute name error in the block PHP.

How has this been tested?

In a Navigation block with nested Submenus, change the Overlay background colour to a non-default value. Make sure the Background colour value is set to default. Publish and check that overlay background colour applies to all the submenus on the front end.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@tellthemachines tellthemachines linked an issue Nov 15, 2021 that may be closed by this pull request
Navigation/Submenu block: Explicit overlay colors do not affect the Submenu on the frontend #36439
Closed
@tellthemachines tellthemachines added [Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Bug An existing feature does not function as intended Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Nov 15, 2021
jasmussen
jasmussen approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Screenshot 2021-11-15 at 09 07 58

@tellthemachines tellthemachines merged commit d59e92b into trunk Nov 17, 2021
@tellthemachines tellthemachines deleted the fix/submenu-background branch November 17, 2021 00:37
@github-actions github-actions bot added this to the Gutenberg 12.0 milestone Nov 17, 2021
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 22, 2021
noisysocks pushed a commit that referenced this pull request Nov 22, 2021
@tellthemachines @noisysocks
Fix background colors in nested submenus. (#36476)
2db5ae6
@noisysocks noisysocks mentioned this pull request Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

@talldan talldan Awaiting requested review from talldan

@georgeh georgeh Awaiting requested review from georgeh

Assignees
No one assigned
Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 12.0
3 participants
@tellthemachines @jasmussen @noisysocks