[Global Styles]: Add block icon next to blocks list #36520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
Global Styles
|
Size Change: +15 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
Nice, thanks! |
ntsekouras
added
the
Backport to WP 6.7 Beta/RC
|
I was also looking into this earlier, based on the meetup notes 😄 I noticed that So there might be an easier way: diff --git a/packages/edit-site/src/components/global-styles/screen-block-list.js b/packages/edit-site/src/components/global-styles/screen-block-list.js
index 5cc822ff4d..740faecd24 100644
--- a/packages/edit-site/src/components/global-styles/screen-block-list.js
+++ b/packages/edit-site/src/components/global-styles/screen-block-list.js
@@ -28,7 +28,7 @@ function BlockMenuItem( { block } ) {
}
return (
- <NavigationButton path={ '/blocks/' + block.name }>
+ <NavigationButton icon={ block.icon } path={ '/blocks/' + block.name }>
{ block.title }
</NavigationButton>
);Just in case we wanna de-duplicate some functionality 😉 |
|
@ockham If I remember properly the |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds the block icon next to the blocks list in Global Styles sidebar.
