Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS fix for 33580. #36759

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Add CSS fix for 33580. #36759

merged 1 commit into from
Nov 30, 2021

Conversation

costdev
Copy link
Contributor

@costdev costdev commented Nov 23, 2021 •
edited
Loading

Description

This PR applies the CSS fix in patch 53801_css03.diff on Trac 53801.

Fixes #33580.

How has this been tested?

Screenshots

Screenshots can be found here.

Types of changes

  • This PR introduces CSS rules to hide non-legacy widget content in the legacy widget previews.
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 23, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @costdev! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@costdev costdev changed the title Add CSS fix. Add CSS fix for 33580. Nov 23, 2021
@noisysocks
Copy link
Member

@draganescu: Could you please review / help land this?

@hellofromtonya hellofromtonya mentioned this pull request Nov 30, 2021
Closed
@noisysocks noisysocks merged commit a306eba into WordPress:trunk Nov 30, 2021
@noisysocks noisysocks added [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Type] Bug An existing feature does not function as intended Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Nov 30, 2021
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 30, 2021
noisysocks pushed a commit that referenced this pull request Nov 30, 2021
@costdev @noisysocks
Add CSS fix. (#36759)
e2a3658
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 30, 2021
@noisysocks noisysocks mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

@draganescu draganescu Awaiting requested review from draganescu

Assignees
No one assigned
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 12.1
Development

Successfully merging this pull request may close these issues.

New Widgets Screen does wp_footer action below each Widget
2 participants
@costdev @noisysocks