Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor: Sync export API #36908

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Site Editor: Sync export API #36908

merged 3 commits into from
Nov 29, 2021

Conversation

Mamaduka
Copy link
Member

Description

Follow up for core PR - WordPress/wordpress-develop#1936

How has this been tested?

Check that the site export tool works as expected.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka mentioned this pull request Nov 26, 2021
Closed
@Mamaduka Mamaduka self-assigned this Nov 26, 2021
@Mamaduka Mamaduka requested a review from walbo November 26, 2021 14:25
walbo
walbo approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@walbo walbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mamaduka
Copy link
Member Author

Thanks for the review, @walbo.

@Mamaduka Mamaduka merged commit 8764c1a into trunk Nov 29, 2021
@Mamaduka Mamaduka deleted the sync/edit-site-export-with-core branch November 29, 2021 05:03
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 29, 2021
@Mamaduka Mamaduka added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Task Issues or PRs that have been broken down into an individual action to take labels Dec 5, 2021
noisysocks pushed a commit that referenced this pull request Dec 6, 2021
@Mamaduka @noisysocks
Site Editor: Sync export API (#36908)
e01295f 
* Site Editor: Sync export API

* Use gutenberg_get_block_templates

* Ignore WP for ZipArchive property
@noisysocks noisysocks mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walbo walbo walbo approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@Mamaduka Mamaduka

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
Gutenberg 12.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mamaduka @walbo