Site Editor: Templat list fallback to slug #36947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
|
Size Change: +15 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
This seems like a sensible fallback, but we should also do everything we can to avoid situations in which templates can be nameless. I noticed that the template renaming UI in the post editor doesn't actually allow you to enter an empty name: name.mp4Can we do that in the template editor too? |
|
@jameskoster, as you mentioned, this is just a fallback. I will also update #36933 to use slug when the template title is empty. |
jameskoster
approved these changes
Nov 29, 2021
7 tasks
Mamaduka
force-pushed
the
fix/template-list-title-fallback
branch
from
3d6a8e6
to
36767e7
Compare
kevin940726
approved these changes
Nov 30, 2021
Mamaduka
force-pushed
the
fix/template-list-title-fallback
branch
from
36767e7
to
db030cc
Compare
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The title isn't required for post types. While we have a "soft" requirement for template titles, it's still possible to have one without it.
Currently, when a template has no title, it's not possible to access it for editing. PR adds fallback to template slug for similar scenarios.
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).