Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selector ordering to ensure theme.json root selector margin takes precedence #36960

Merged
merged 7 commits into from
Dec 9, 2021
Merged

Allow selector ordering to ensure theme.json root selector margin takes precedence #36960

merged 7 commits into from
Dec 9, 2021

Commits on Dec 1, 2021

  1. Set default margin on body prior to generating styles from theme.json

    @getdave
    getdave committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    09c052b View commit details
    Browse the repository at this point in the history

  2. Add additional context to comment 

    Addresses #36960 (comment)
    @getdave
    getdave committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    8c827ca View commit details
    Browse the repository at this point in the history

  3. Restore simple version of body rule 

    Also avoids creating failing unit tests due to a single space character changing in a snaphshot!
    @getdave
    getdave committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    7c2969d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2021

  1. Update with fixes made in Core patch 

    See WordPress/wordpress-develop#1989
    @getdave
    getdave committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    8132d20 View commit details
    Browse the repository at this point in the history

  2. Fix output now includes new line.

    @getdave
    getdave committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    6afbc51 View commit details
    Browse the repository at this point in the history

  3. Fix tests relating to spacing

    @getdave
    getdave committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    4b7b15a View commit details
    Browse the repository at this point in the history

  4. Fix test to put body CSS reset first

    @getdave
    getdave committed Dec 9, 2021
    Configuration menu
    Copy the full SHA
    0a52906 View commit details
    Browse the repository at this point in the history