Site Editor: Add the dark frame #36995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
jameskoster
requested review from
shaunandrews,
jasmussen,
paaljoachim and
kellychoffman
3 tasks
|
Size Change: +27 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
Thanks for the PR! It's a great way to at least test out the idea. Here's a GIF:
I like that there's a clear place to click to deselect. The resize handles are nice, but without a way to control them with the keyboard I don't think we can entirely remove the preview dropdown. The frame takes up a lot of space, which is okay on larger breakpoints, but is a bit tricky on the smaller ones. I have this feeling that we will eventually want this frame to land, but that it's probably not quite as simple as just this one PR. That seems to harmonize with Matías comment here as well: that we might do it, but it's perhaps a wee bit early still. |
|
The dark frame adds an visual element which is not really a part of the layout. It is just used for visual resize purpose as I see it. Keeping the backend as similar to the frontend as possible would be very helpful. Any extra elements that are not a part of the layout can easily become a distraction. Before: This looks and feels pretty much close to what one would see on the frontend. After:
This creates a black-white contrast we usually see in the backend WordPress left sidebar menu in relation to each section one visits. If the purpose is to give a clear signal that one can drag the resize handlebars to check resolution sizes than this creates a visual disturbance is how one would see the layout. Adding the black frame also makes the important layout area smaller. I have been and am pretty vocal about not using a high contrast frame, as is currently used for page templates. I hope to see this change to giving back more screen real estate to the user by keeping the backend as similar to the frontend as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a couple of issues, the idea of adding the "frame" that appears when editing a template part (or a template in the post editor) has arisen: #36535 #36977
To summarise: The frame provides an empty clickable area that makes it easier to deselect blocks. It also creates space for block toolbars that appear close to the top of the canvas.
There is undoubtedly a much better way to do things on the code side, but we can fix that later. This PR is mostly just to get an idea of how things feel with the frame in place so that we can make a better decision around whether or not to add it.