-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Block Library - Navigation]: Fix vertical layout #37009
Conversation
Thanks for the PR. What's a good way to test it? |
Sorry about that 😄 - I updated the PR's description |
20fbbd3
to
c8d14bd
Compare
Thank you. Tests well for me. I can't speak well to the inner workings, but I'll be happy to give a thumbs up if you have high confidence in this one. |
In general we need to review the whole |
Fixes: #36902
This PR fixes a regression introduced here: #36292.
Testing instructions
Navigation
block and add a couple of itemslayout
orientation tovertical
(do not change content justification)vertical
nowIn general I think something like this should be used to get the
default
block layout inedit
function. Now in Navigation block we provide some layout defaults which seems that it shouldn't - I haven't checked in depth yet as the block itself is really convoluted.The specific problem was that we needed the
--layout-direction
attribute which wasn't added iflayout.justifyContent
was empty.The logic about
setCascadingProperties
needs more looking. I noticed the 'spread' of items in vertical orientation (Search in Navigation, Social Links) and I believe there must be similar css rules like this fix.Screen.Recording.2021-11-30.at.8.39.43.PM.mov