Border panel: Update the value of the ColorPicker when color is cleared #37048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you set border width to zero, the color attributes are cleared. The color control was not picking up on this change to the attr, so the previously selected color still appeared to be selected in the panel.
7 tasks
stacimc
added
[Feature] Design Tools
|
Size Change: +18 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Dec 2, 2021
stacimc
changed the title
stacimc
requested review from
aaronrobertshaw
and removed request for
aaronrobertshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37047
Description
When border width is set to zero, any selections for the color and style controls should be cleared. The attributes are correctly getting cleared, but the Color controls do not visually reflect this -- the color appears to remain selected. This PR just updates the Color controls to detect this change to the attributes.
How has this been tested?
Test with both color presets and a custom border color.
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).