Card: support the extraSmall option for the size prop
#37097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ciampo
added
[Feature] Component System
|
Size Change: +29 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
ciampo
commented
Dec 3, 2021
TimothyBJacobs
added
the
Backport to WP 6.7 Beta/RC
|
This looks great, thanks @ciampo! Adding the backport label as this is causing breakage on 5.9. |
tyxla
approved these changes
Dec 5, 2021
noisysocks
force-pushed
the
fix/components-card-size-extrasmall
branch
from
6b92c49 to
17f25d1
Compare
|
I rebased this to (hopefully) fix failing tests. |
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
* `Card`: support the `extraSmall` option for the `size` prop * Unit tests * CHANGELOG * Remove unnecessary markup from unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported in #32566 (comment) , when the
Cardcomponent was last updated, a change was introduced to the list of values accepted by thesizeprop.In particular, prior to that PR, the
Cardcomponent was able to accept theextraSmallvalue, while since that PR, it now accepts thexSmallvalue instead.This PR introduces support for the legacy
extraSmallvalue, avoiding a breaking change for the consumers of the component that are still using the older value.Note: the older
extraSmallvalue is not mentioned in the README on purpose, in order to encourage folks to use the newerxSmallvalue.How has this been tested?
extraSmallas a potential value forsizeTypes of changes
Fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).