Refactor the gutenberg_is_fse_theme function to use wp_is_block_theme
#37161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a note about future deprecation of the gutenberg_is_fse_theme function.
anton-vlasenko
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
anton-vlasenko
added
[Type] Enhancement
anton-vlasenko
changed the title
wp_is_block_template
anton-vlasenko
changed the title
wp_is_block_templategutenberg_is_fse_theme function to use wp_is_block_template
anton-vlasenko
changed the title
gutenberg_is_fse_theme function to use wp_is_block_templategutenberg_is_fse_theme function to use wp_is_block_theme
noisysocks
added
the
Backport to WP 6.7 Beta/RC
|
I was wondering if I need to use the |
|
It's not really necessary but nice to keep |
youknowriad
pushed a commit
that referenced
this pull request
Dec 8, 2021
…eme` (#37161) * Rename wp_is_block_template_theme to wp_is_block_theme * Use wp_is_block_theme (if it's available). Add a note about future deprecation of the gutenberg_is_fse_theme function.
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
…eme` (#37161) * Rename wp_is_block_template_theme to wp_is_block_theme * Use wp_is_block_theme (if it's available). Add a note about future deprecation of the gutenberg_is_fse_theme function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged once WordPress/wordpress-develop#2014 gets merged into WordPress Core. Please don't merge this PR now.
Description
This PR aims to refactor the
gutenberg_is_fse_themefunction.It should use
wp_is_block_templateinternally (if it's available).Also, it adds a note about the future deprecation of the
gutenberg_is_fse_themefunction.This PR should be merged once WordPress/wordpress-develop#2014 gets merged into WordPress Core.
Fixes #37162
How has this been tested?
Screenshots
No screenshots are needed.
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).