Hide remove control point when removing would break gradient control #37186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
7 tasks
|
Thanks a whole bunch for the PR! This feels like an excellent step forward. I'll give this one a quick review and hopefully green check tomorrow when I get a chance, but I'll CC some folks in case they can get to it in the mean time. Thank you! |
jasmussen
added
[Type] Bug
georgeh
approved these changes
Dec 7, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hides the "Remove control point" button when there are two or fewer control points as mentioned in #37178. Removing any at that point breaks the UI a little as you can't have a gradient with just one color, and having the button enabled means you could endlessly remove the control point.
Prior behavior:
How has this been tested?
In the gradient picker add and remove control points to see that the remove button hides when there are fewer than two points in the gradient.
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).