Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugins styles customization support #37208

Closed
wants to merge 10 commits into from
Closed

Add plugins styles customization support #37208

wants to merge 10 commits into from

Conversation

Lucisu
Copy link
Contributor

@Lucisu Lucisu commented Dec 7, 2021 •
edited
Loading

Description

This pull request adds three filters that allow plugins to customize Global Styles and theme.json files.

It solves #37206

How has this been tested?

Just added filters, so my tests were just loading everything, pretty straightforward.

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

gutenbergplugin and others added 10 commits November 17, 2021 19:12
@gutenbergplugin
Bump plugin version to 12.0.0-rc.1
a1cead2
@gutenbergplugin
Update Changelog for 12.0.0-rc.1
0d7c35c
@gutenbergplugin
Bump plugin version to 12.0.0
f6bbb33
@gutenbergplugin
Update Changelog for 12.0.0
660f35a
@xknown @noahtallen
Add caching to WP_Theme_JSON_Resolver_Gutenberg::get_user_data_from_c…
408481d 
…ustom_post_type() (WordPress#36584)

* Add caching to WP_Theme_JSON_Resolver_Gutenberg::get_user_data_from_custom_post_type

Refactor
`WP_Theme_JSON_Resolver_Gutenberg::get_user_data_from_custom_post_type`
to add caching to the `wp_global_styles` post type lookup, and also to
remove the duplicate code added in
`gutenberg_add_active_global_styles_link`.

Fixes WordPress#36574

* Add unit tests

* Use the correct query filter

* Use wp_cache_set instead of wp_cache_add.

* Remove the filter when finished.

* Simplify the if blocks
@gutenbergplugin
Bump plugin version to 12.0.1
5469411
@gutenbergplugin
Update Changelog for 12.0.1
fe06647
@ramonjd @ockham
Block Styles: check for existence of scroll container (WordPress#37010)
5be0ffd 
* Let's check if the scrollContainer can be found before trying to use its property `scrollTop`.

* Moving default top position to a const and moving the comment.
@gutenbergplugin
Bump plugin version to 12.0.2
1695ed1
@Lucisu
Allowing plugins to customize global styles and theme.json files "on …
b9c015a 
…the fly"
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Dec 7, 2021

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Lucisu! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Lucisu
Copy link
Contributor Author

Lucisu commented Dec 7, 2021

I just noticed I added the commit to the 12.0.2, I'll try to fix it later

@aristath
Copy link
Member

aristath commented Dec 8, 2021

Hey there @Lucisu, thank you for this PR!
I'm not sure what this is trying to accomplish though. It looks like you're trying to allow changing the path of the theme.json file? If so, for what purpose?
We can already load alternative data by using the WP_Query filters when the parser tries to get the user-data 🤔

@skorasaurus skorasaurus added Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] Needs More Info Follow-up required in order to be actionable. labels Sep 27, 2022
@Lucisu
Copy link
Contributor Author

Lucisu commented Oct 3, 2022

Hello, @skorasaurus! I'm sorry for the delay.

So, I remember that when I sent this pull request, I was developing a custom plugin that would inject some content out of the user data in the theme.json in runtime.

I didn't find any filters to accomplish this, so I had to create a workaround, and not very beautiful.

Please, let me know if it makes sense.

Thank you!

@Mamaduka
Copy link
Member

Mamaduka commented Oct 3, 2022

Hi, @Lucisu

The #44015 introduced a few hooks that might serve the same purpose.

Handbook: https://developer.wordpress.org/block-editor/reference-guides/filters/global-styles-filters/.

Let me know if we can close this PR.

Thanks,

George

@Lucisu
Copy link
Contributor Author

Lucisu commented Oct 3, 2022

Hey there! Yep, that will solve the problem!

Thanks ;)

@Mamaduka Mamaduka closed this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix Awaiting requested review from ellatrix ellatrix is a code owner

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Lucisu @aristath @Mamaduka @skorasaurus @gutenbergplugin @xknown @ramonjd