Font sizes: update default values #37381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
added
the
[Feature] Themes
|
Size Change: +319 B (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
oandregal
added
the
Global Styles
mtias
reviewed
Dec 14, 2021
| @@ -6,6 +6,9 @@ | |||
| @include background-colors-deprecated(); | |||
| @include foreground-colors-deprecated(); | |||
| @include gradient-colors-deprecated(); | |||
| --wp--preset--font-size--normal: 16px; | |||
There was a problem hiding this comment.
Shouldn't these be defined in the mixin instead?
There was a problem hiding this comment.
Had to remove the mixin #37381 (comment)
There was a problem hiding this comment.
Got it. Let's add a comment that these are for compatibility as well.
mtias
reviewed
Dec 14, 2021
oandregal
commented
Dec 14, 2021
| @@ -6,6 +6,9 @@ | |||
| @include background-colors-deprecated(); | |||
| @include foreground-colors-deprecated(); | |||
| @include gradient-colors-deprecated(); | |||
| --wp--preset--font-size--normal: 16px; | |||
| --wp--preset--font-size--huge: 42px; | |||
| @include font-sizes-deprecated(); | |||
There was a problem hiding this comment.
By doing this, the classes will now be :root .has-font-size-<slug> and the specificity 020, which increases it from before (010) where we only used the class.
There was a problem hiding this comment.
At 669f4f0 removed them from the mixin and added below: it keeps its specificity and work like the other legacy font sizes defined below.
mtias
approved these changes
Dec 14, 2021
|
Thanks for the work here. Excited to see this tuneup and simplification. I tried the following in my theme: Note above the omission of The above GIF by the way is identical to trunk, with the same theme.json provided. That's good as far as back compat goes! Next I tested creating 5 paragraphs with the existing sizes, then checking out this PR to see what happened. Here's how that looks: Markup: Then I tried checking out this branch:
Note the two custom sizes:
Notably the fallback values appear to work, as the visual appearance is identical. |
kjellr
approved these changes
Dec 14, 2021
There was a problem hiding this comment.
I see the same a @jasmussen. Fallbacks seem to work just fine. Code looks good too.
|
I've given this a bit of a test as well. ✅ The code changes make sense. I couldn't see an easy option to display more meaningful values in the |
That had felt weird to me as well when first noticed this behavior previously and while I don't have all the context, I think it makes sense. If we select one of the available sizes/presets we only store the |
ntsekouras
approved these changes
Dec 15, 2021
|
Thanks all for the quick testing. I've done some myself and this appears to work as expected. I'm going to merge this and mark it to be merged in the next beta. |
oandregal
added
the
Backport to WP 6.7 Beta/RC
Wanted to follow up on this: with the current code, when using the segmented control it shows "undefined" labels at the top and when using the dropdown it shows only the numbers. Nik and I looked at this and he's going to prepare a new PR to pull the names from the defaults if the theme doesn't provide them. |
|
Sounds excellent 👌 |
7 tasks
|
Yes, to clarify the above — the theme provided a "normal" font size preset, but the preset supplied by It's no longer an issue for TT2 since we don't supply a "normal" preset, but wanted to flag it in case it's an issue. |
|
Thanks for reporting. I've prepared a fix at #37526 (lowers the specificity of the CSS custom properties). |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37378
Related #37038
Testing
.has-<slug>-font-size) or variables (--wp--preset--font-size-<slug>) should still work as expected.