-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site Editor: Add keyboard shortcut help modal #37650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Enhancement
A suggestion for improvement.
labels
Dec 29, 2021
Size Change: +1.34 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
added
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Dec 29, 2021
kevin940726
reviewed
Jan 3, 2022
packages/edit-site/src/plugins/keyboard-shortcut-help-menu-item.js
Outdated
Show resolved
Hide resolved
Mamaduka
force-pushed
the
add/edit-site-shortcuts-modal
branch
from
January 3, 2022 12:51
25b92b8
to
6f6bc84
Compare
kevin940726
approved these changes
Jan 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work as expected! Thank you!
packages/edit-site/src/components/header/tools-more-menu-group/index.js
Outdated
Show resolved
Hide resolved
Thanks for the review, @kevin940726. |
Mamaduka
removed
the
Backport to WP Minor Release
Pull request that needs to be backported to a WordPress minor release
label
Feb 16, 2022
Mamaduka
added a commit
that referenced
this pull request
Feb 16, 2022
* Site Editor: Add keyboard shortcut help modal * Text formatting shortcuts * Don't use plugin to render more menu tools group * Remove fragment
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Site Editor
Related to the overarching Site Editor (formerly "full site editing")
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #21245.
PR adds keyboard shortcuts help modal to the "More tools and options" dropdown.
How has this been tested?
Screenshots
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).