Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block spacing: block-level axial gap block support #37736

Merged
merged 10 commits into from
Mar 22, 2022
Merged

Block spacing: block-level axial gap block support #37736

merged 10 commits into from
Mar 22, 2022
+153 −18

Commits on Mar 21, 2022

  1. Initial commit: splitting the gap value to allow for axial gap values

    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    1f7a1be View commit details
    Browse the repository at this point in the history

  2. Checking for object. Now passing complete object to box control.

    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    9ff0734 View commit details
    Browse the repository at this point in the history

  3. Providing a default value for split gap values, where one is `undefin… 

    …ed`.
    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    72021d8 View commit details
    Browse the repository at this point in the history

  4. This is the first commit that switches the blockGap over to use to an… 

    … object. We're using the `top` and `left` properties of the BoxControl next value to represent row and column values.

Reverting some block.json changes.
Ensuring that we cater for blockGap string values.

Reverting some block.json changes.
Ensuring that we cater for blockGap string values.
Adding tests.
    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    de6da58 View commit details
    Browse the repository at this point in the history

  5. margin-top should take a single value

    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    be909d7 View commit details
    Browse the repository at this point in the history

  6. null coalescing operator (??) is not present in PHP

    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    34b7f8c View commit details
    Browse the repository at this point in the history

  7. Checking for gap array items before using them.

    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    2191831 View commit details
    Browse the repository at this point in the history

  8. Using --wp--style--block-gap as the fallback for split values

    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    119333b View commit details
    Browse the repository at this point in the history

  9. Returning null instead of the argument in getGapCSSValue and updated … 

    …tests

Added comment to explain how we build and pass the boxcontrol component value.
    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    765ca94 View commit details
    Browse the repository at this point in the history

  10. Rolling back using the gap CSS var as a fallback since the CSS var ca… 

    …n theoretically be something like "24px 54px" or some other manifestation of the shorthand value.
    @ramonjd
    ramonjd committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    b618d4e View commit details
    Browse the repository at this point in the history