Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Borders: Add new BorderControl component #37769

Merged
merged 31 commits into from
Mar 24, 2022
Merged

Borders: Add new BorderControl component #37769

merged 31 commits into from
Mar 24, 2022

Commits on Mar 15, 2022

  1. Add BorderControl component 

    This provides a new component that allows configuration of border color, style, and width.
    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    ad80204 View commit details
    Browse the repository at this point in the history

  2. Improve docs and comments for width prop

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    08a4aaf View commit details
    Browse the repository at this point in the history

  3. Target BackdropUI instead of div for removing border

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    45b2fd9 View commit details
    Browse the repository at this point in the history

  4. Add RTL styles

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    3c072f3 View commit details
    Browse the repository at this point in the history

  5. Switch BorderControlStylePicker to use inner Flex component

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a6be837 View commit details
    Browse the repository at this point in the history

  6. Refactor label styles

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    95a74a7 View commit details
    Browse the repository at this point in the history

  7. Add cx to useMemo deps

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a7ecb60 View commit details
    Browse the repository at this point in the history

  8. Use StyledField to target slider margin removal

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a3fd0e0 View commit details
    Browse the repository at this point in the history

  9. Fix type ignoring for color components

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    f6cbe7f View commit details
    Browse the repository at this point in the history

  10. Move color indicator wrapper styles to dynamic class

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    8d1c5a1 View commit details
    Browse the repository at this point in the history

  11. Use React.ForwardRef<any> for typing

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    51574d6 View commit details
    Browse the repository at this point in the history

  12. Use Root to target UnitControl wrapper

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    3e23b82 View commit details
    Browse the repository at this point in the history

  13. Add default to docs for shouldSanitizeBorder

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    757da54 View commit details
    Browse the repository at this point in the history

  14. Add default to type docs for enableStyle

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    c1f7f53 View commit details
    Browse the repository at this point in the history

  15. Update width type to CSSProperties['width']

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    81bfad0 View commit details
    Browse the repository at this point in the history

  16. Add default for enableStyle to dropdown js docs

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    cf87f11 View commit details
    Browse the repository at this point in the history

  17. Remove extraneous width style

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    0b79b77 View commit details
    Browse the repository at this point in the history

  18. Fix unit and value parsing after changes to UnitControl utils

    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    57d87ef View commit details
    Browse the repository at this point in the history

  19. Make inner unit control fill available height 

    Using `size="__unstable-large"` Increases padding on input, increases overall height etc and generally messes up more than it fixes. Simply switching the HStack to alignment="stretch" visually achieves the desired result.
    @aaronrobertshaw
    aaronrobertshaw committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    202800c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Add tooltip for border style options

    @aaronrobertshaw
    aaronrobertshaw committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    dfe7470 View commit details
    Browse the repository at this point in the history

  2. Improve typing for colors array 

    Colors can have multiple origins but the current typing doesn't reflect this.
    @aaronrobertshaw
    aaronrobertshaw committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    9be938d View commit details
    Browse the repository at this point in the history

  3. Improve aria labels for color and style popover toggle button

    @aaronrobertshaw
    aaronrobertshaw committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    1782b43 View commit details
    Browse the repository at this point in the history

  4. Comment explaining color indicator styling choice

    @aaronrobertshaw
    aaronrobertshaw committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    b17da1a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Only show border on indicator when style has been selected

    @aaronrobertshaw
    aaronrobertshaw committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    b8da8d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Fix RTL handling and style naming

    @aaronrobertshaw
    aaronrobertshaw committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    9829605 View commit details
    Browse the repository at this point in the history

  2. Allow color and style picker to use flyout positioning 

    This passes through the __experimentalIsRenderedInSidebar prop to the border control dropdown which can then use that to determine the dropdown's position.
    @aaronrobertshaw
    aaronrobertshaw committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    32e0120 View commit details
    Browse the repository at this point in the history

  3. Add multi origin colors to storybook example

    @aaronrobertshaw
    aaronrobertshaw committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    4f538d6 View commit details
    Browse the repository at this point in the history

  4. Make dropdown header optional via new prop

    @aaronrobertshaw
    aaronrobertshaw committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    345b49a View commit details
    Browse the repository at this point in the history

  5. Update unit tests for optional color/style dropdown header

    @aaronrobertshaw
    aaronrobertshaw committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    be99ab1 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Use more concise CSS rule to remove whitespace

    @aaronrobertshaw
    aaronrobertshaw committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    02562bb View commit details
    Browse the repository at this point in the history

  2. Fix tooltips within color/style dropdown

    @aaronrobertshaw
    aaronrobertshaw committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    535cd0d View commit details
    Browse the repository at this point in the history