PostLockedModal: Update action buttons markup #37837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Editor
Mamaduka
commented
Jan 10, 2022
| @@ -4,9 +4,6 @@ | |||
|
|
|||
| .editor-post-locked-modal__buttons { | |||
| margin-top: $grid-unit-30; | |||
There was a problem hiding this comment.
I wanted to note that this should be a $grid-unit-15, and I think we're only using $grid-unit-30 because of margin collapse.
There was a problem hiding this comment.
Good thought. I'd love to actually see the more stack-based approach for contents inside here, so we don't have to specify this margin at all, something like this perhaps.
There was a problem hiding this comment.
I agree, or we should switch to top margins for paragraphs.
|
Size Change: +5 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Very nice, works as intended, thank you!
I did notice an issue in testing this, but that's separate and I'll try and look into it:
On a separate note and mostly a general thought on the direction of modals for the project, I'd love to see further componentization and unification. Something like #34153 is good inspiration.
javierarce
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Except for the thing @jasmussen mentions about the responsive view, this looks perfect to me.
|
Thank you for testing. I see that @jasmussen has already started working on follow-up PR 🦸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR updates Post Locked modal action buttons markup to match other similar models in the core.
Part of #37725.
How has this been tested?
Modal should look the same design-wise.
Create two admin user accounts. Save a post as one user, then log in as the other user in an incognito mode and load the same post.
Screenshots
Types of changes
Code Quality
Checklist:
*.native.jsfiles for terms that need renaming or removal).