ExternalLink: Update icon to be smaller, have no margin. #37859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
8 tasks
|
Size Change: -12 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
ciampo
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Thank you for constantly refining our components, @jasmussen ! (and for pre-emptively adding an entry to the changelog!)
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #37852.
The
ExternalLinkcomponent appears to exist to enable the visual indication of a link that points to an external URL, i.e. to be used as part of a sentence or prose. But at 1.4em size and with margin around it, the icon does not feel harmoniusly balanced with the text, looking both too large, and as if there's a trailing space after it:This PR make the icon maller, and remove the margin to make it feel like it's part of the link:
How has this been tested?
Test in Storybook. Before:
After:
Checklist:
*.native.jsfiles for terms that need renaming or removal).