Fix flaky classic block conversion undo test #37933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
|
This is a very minor fix, so I'll just go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36123. Or at least attempts to.
This test inserts a classic block with a gallery. Converts it to blocks, and then uses undo to convert it back to a classic block again.
The error happens just after the undo step, the test expects a classic block but instead the converted block content is still present:
I think the test needs to wait for the
undoto take effect, but it doesn't and the assertion is happening too quickly. I've added awaitForSelectorthat waits for the classic block to be present.