Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove text decoration from Nav block #37963

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Jan 14, 2022

Description

Temporary patch for buggy behaviour in Navigation block text-decoration, as described in #37726. We can re-enable text decoration once #36345 or similar is merged.

This follows on from discussion in #37738.

How has this been tested?

Create a Navigation block. In the block sidebar, under "Typography", the "Decoration" option should no longer be available.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@tellthemachines tellthemachines added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jan 14, 2022
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it's working well. Before:
Screenshot 2022-01-14 at 08 11 42
Screenshot 2022-01-14 at 08 08 53

After:

Screenshot 2022-01-14 at 08 10 44

Screenshot 2022-01-14 at 08 10 38

As you note, the feature will return, but since the current implementation is buggy in a few unexpected ways, it seems best to not launch with this.

@jasmussen
Copy link
Contributor

@noisysocks Can we backport this one, do you think?

@noisysocks noisysocks added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jan 17, 2022
@noisysocks noisysocks merged commit 5c3f884 into trunk Jan 17, 2022
@noisysocks noisysocks deleted the fix/temp-remove-text-decoration branch January 17, 2022 00:14
@github-actions github-actions bot added this to the Gutenberg 12.5 milestone Jan 17, 2022
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants