Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duotone: Allow users to specify custom filters #38055

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Duotone: Allow users to specify custom filters #38055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/compat/wordpress-5.9/get-global-styles-and-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ function wp_get_global_styles_svg_filters() {

$supports_theme_json = WP_Theme_JSON_Resolver_Gutenberg::theme_has_support();

$origins = array( 'default', 'theme' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, the code in the folder lib/compat/wordpress-5.9 is expected to be part of WordPress 5.9? Is this being ported to WordPress core? I presume it isn't, so we'd need to revert this PR and look at different ways to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert here: #38150

Copy link
Contributor

@ajlende ajlende Jan 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we just port to core instead of reverting and working around it here? Is that just more complicated or something?

Copy link
Member

@oandregal oandregal Jan 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if the change was part of 5.9, this would have been fine. Though when this landed only the 5.9 leads could approve PRs for core and that would need to happen before.

In general, code in a lib/compat/wordpress-X.Y folder needs to be in sync with what was shipped in that same WordPress X.Y release.

$origins = array( 'default', 'theme', 'custom' );
if ( ! $supports_theme_json ) {
$origins = array( 'default' );
}
Expand Down