Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DropdownMenu to typescript #38354

Closed

Conversation

rajnish93
Copy link

@rajnish93 rajnish93 commented Jan 30, 2022

Description

Refactor DropdownMenu to TypeScript #35744

Testing Instructions

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@rajnish93 rajnish93 requested a review from ajitbohra as a code owner January 30, 2022 17:03
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jan 30, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rajnish93! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@amustaque97 amustaque97 added [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality labels Jan 30, 2022
@ciampo ciampo self-requested a review January 31, 2022 12:59
@ciampo
Copy link
Contributor

ciampo commented Jan 31, 2022

Hey @rajnish93 , thank you for your effort.

As explained in #35744 (comment), it may still be a little bit early to work on this task — it's probably better if we champion a few refactors first to understand any caveats along the way!

I would also ask you to mark this PR as a draft while work is in progress — thank you!

@ciampo ciampo added the [Feature] Component System WordPress component system label Jan 31, 2022
@ciampo ciampo requested a review from mirka January 31, 2022 13:04
@rajnish93 rajnish93 marked this pull request as draft January 31, 2022 16:49
@t-hamano
Copy link
Contributor

t-hamano commented Dec 8, 2023

It seems that the refactoring of the Dropdownmenu component has been completed in #50187, so I would like to close this PR. If there's anything I've missed, please comment.

@t-hamano t-hamano closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Component System WordPress component system First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
Status: Abandoned ⛔️
Development

Successfully merging this pull request may close these issues.

4 participants