[RNMobile] Add integration test helpers #38619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
|
Size Change: +1.56 kB (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
fluiddot
force-pushed
the
rnmobile/add/integration-test-helpers
branch
2 times, most recently
from
f246b8e
to
da5842f
Compare
fluiddot
force-pushed
the
rnmobile/add/integration-test-helpers
branch
from
da5842f
to
73b35fd
Compare
fluiddot
force-pushed
the
rnmobile/add/integration-test-helpers
branch
from
27bb33a
to
b6ec278
Compare
fluiddot
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
fluiddot
removed request for
juanmaguitar,
ajitbohra,
ryanwelcher and
fabiankaegy
dcalhoun
reviewed
Jun 17, 2022
There was a problem hiding this comment.
Thanks for putting this together! It is quite obvious that a lot of thought went into the organization and potential value gained from the abstractions. 🙇🏻
I left a few questions that I hope will help me better understand some of the code. None are blockers by any means.
dcalhoun
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR incorporates a set of helper functions for integration tests.
NOTE: I'm planning to also move the helpers from
block-draggable/test/helpers.native.jsin another PR.Why?
This is part of an ongoing effort for making easier writing integration tests for the native version.
How?
The helpers have been extracted mainly from the Gallery block test cases, as it incorporated several of them. A new folder named
integration-test-helpershas been added totest/nativepath, in this folder we'll hold the helpers, ideally one file per helper.In this PR we're incorporating the following ones, some of them were already being exposed from
test/native/helpers.jsfile:addBlock- Adds a block via the block picker.advanceAnimationByTime,advanceAnimationByFrame- Advance Reanimated animations by time or frames.dismissModal- Dismisses a modal.getBlock- Gets a block from the root block list.getEditorHtml- Gets the current HTML output of the editor.getInnerBlock- Gets an inner block from another block.initializeEditor- Initialize an editor for test assertions.openBlockSettings- Opens the block settings of the current selected block.changeAndSelectTextOfRichText- Changes the text and selection of a RichText component.changeTextOfRichText- Changes the text of a RichText component.pasteIntoRichText- Paste content into a RichText component.setupCoreBlocks- Registers all core blocks or a specific list of blocks before running tests (once the tests are run, all registered blocks are unregistered).setupMediaPicker- Sets up Media Picker mock functions.setupMediaUpload- Sets up the media upload mock functions for testing.changeTextOfTextInput- Changes the text of a TextInput component.triggerBlockListLayout- Helper for ensuring that all items of a Block List component are rendered.waitForModalVisible- Waits for a modal to be visible.waitForStoreResolvers- Executes a function that triggers store resolvers and waits for them to be finished.waitFor- Custom implementation of the "waitFor" utility from@testing-library/react-nativelibrary.withFakeTimers- Set up fake timers for executing a function and restores them afterwards.withReanimatedTimer- Prepare timers for executing a function that uses the Reanimated APIs.NOTE: The above helpers are also listed in a README file that is referenced in the React Native Integration Test Guide.
Testing Instructions
npm run native test.Screenshots or screencast
N/A