Mobile: Improve npm clean scripts for react-native-editor #38752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
added
Mobile App - i.e. Android or iOS
mchowning
commented
Feb 11, 2022
| "clean:install": "npm run clean; npm install", | ||
| "clean:jest": "jest --clearCache --config ../../test/native/jest.config.js; rm -rf $TMPDIR/jest_*", | ||
| "clean:metro": "rm -rf $TMPDIR/metro-cache-*;", | ||
| "clean:metro": "rm -rf $TMPDIR/metro-cache/", | ||
| "clean:react": "rm -rf $TMPDIR/react-*", |
There was a problem hiding this comment.
I'm not seeing any $TMPDIR/react-* files. Perhaps we don't need the clean:react command anymore?
There was a problem hiding this comment.
I don't have any $TMPDIR/react-* either, probably ok to remove the command.
There was a problem hiding this comment.
👍 Updated the PR to remove clean:react as well. I'll re-request your review in case you have any additional thoughts.
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
jhnstn
approved these changes
Feb 11, 2022
These files don't seem to get created anymore, so we don't need to clean them either
mchowning
force-pushed
the
rnmobile/update_cache_refs
branch
from
0443860 to
f757670
Compare
cbravobernal
added
[Tool] WP Scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the clean scripts to delete the proper cache files.
It seems like these cache files have moved (possibly due to one of the React Native upgrades) since these scripts were last updated. I am basing these updates on the files that I am seeing on my local machine. Let me know if you think that these might be different for different people.
I did notice that there was also a
kotlin-compiler-in-wordpressreactnativebridge-17156846827643056472.alivein the$TMPDIR. I am not adding anything to remove that at this time since I don't know what it is used for, but it might be something we want to consider in the future.Testing Instructions
npm run bundlefrom gutenberg-mobilehaste-map-metro-*file and ametro-cache/file in "$TMPDIR"npm run cleanfrom gutenberg-mobile$TMPDIR/(apart from the earlier mentionedkotlin-compiler-in...file.Types of changes
Infrastructure improvement
Checklist:
*.native.jsfiles for terms that need renaming or removal).