[RNMobile] Fix Jest module name mapper for WP packages that use Typescript #38856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#4589
Description
After #37978 was merged, the mobile unit tests began to fail because the package
@wordpress/style-enginecouldn't be found. This is caused due to the way we set the module name mapper in the Jest configuration. As you can see below, we expect that the packages have anindex.jswhich is not the case for package@wordpress/style-engine, as it uses Typescript and the index file hastsextension (i.e.index.ts).gutenberg/test/native/jest.config.js
Lines 18 to 20 in efc835c
This has been addressed by updating the glob pattern and including the
tsextension.NOTE: Not sure why but the mobile unit test CI job was passing even with errors (reference) due to this issue. We should investigate further why that happened because it would have helped to identify this problem earlier.
Testing Instructions
npm run native test.Unit Tests / Mobilepasses.Screenshots
N/A
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).