Template Parts: Limit slug to Latin chars #38861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Template Part
|
@kevin940726, I plan to extract this method into a utility function in a separate PR. However, I'm trying to keep fixes simple to backport in a minor release for now. |
Mamaduka
added
the
Backport to WP Minor Release
|
Size Change: +30 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
gwwar
reviewed
Mar 3, 2022
| // If we have `area` set from block attributes, means an exposed | ||
| // block variation was inserted. So add this prop to the template | ||
| // part entity on creation. Afterwards remove `area` value from | ||
| // block attributes. | ||
| const record = { | ||
| title, | ||
| slug: kebabCase( title ), | ||
| slug: cleanSlug, |
Mamaduka
force-pushed
the
fix/template-parts-non-latin-slug
branch
from
95d94ea to
8c19f67
Compare
Mamaduka
removed
the
Backport to WP Minor Release
|
I tried updating the REST API schema to use pattern that supports non-Latin chars; it didn't work that well 😅 Let's ship this bandaid patch in 6.0 and try to bring non-Latin chars support to the template endpoint in the next major release. |
|
Hi, @kevin940726 Should we merge this one as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up of #38695 based on this comment #38160 (comment)
Testing Instructions
私のテンプレートパーツのテストorქართული ნაწილი.Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).