Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group: Update block supports. #38962

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Group: Update block supports. #38962

merged 1 commit into from
Feb 21, 2022

Conversation

ndiego
Copy link
Member

@ndiego ndiego commented Feb 21, 2022

Description

Margin support for Group blocks was added in #37344. This PR updates the core block documentation to reflect this.

Types of changes

Updated docs.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@ndiego
Docs: Update Group block supports
047a52a 
Margin support for Group blocks was added in #37344.
@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Feb 21, 2022
@ndiego ndiego requested a review from Mamaduka February 21, 2022 16:40
@ndiego ndiego self-assigned this Feb 21, 2022
Mamaduka
Mamaduka approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up, @ndiego.

@ndiego ndiego merged commit 09cf5a0 into trunk Feb 21, 2022
@ndiego ndiego deleted the docs/update-group-block-supports branch February 21, 2022 17:21
@github-actions github-actions bot added this to the Gutenberg 12.7 milestone Feb 21, 2022
@cbravobernal cbravobernal changed the title Docs: Update Group block supports Group: Update block supports. Feb 26, 2022
@cbravobernal cbravobernal added the [Package] Block library /packages/block-library label Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mkaz mkaz Awaiting requested review from mkaz

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

Assignees

@ndiego ndiego

Labels
[Package] Block library /packages/block-library [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 12.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ndiego @Mamaduka @cbravobernal