-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirmdialog: add custom button text #38994
Confirmdialog: add custom button text #38994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice enhancement! If you could update the component readme and add a changelog entry that would be great.
Comments are mostly code health stuff — I thought you'd might want some context around the general components work that's going on, given your interest in the squad 🙌
9215b53
to
750e4d3
Compare
Co-authored-by: Lena Morita <lena@jaguchi.com>
Component readme and changelog updated (7c46610) ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're in good shape!
Co-authored-by: Lena Morita <lena@jaguchi.com>
Description
Follow up to #37602 (comment), this PR adds the ability to set custom label text for the confirm and cancel buttons in the experimental
ConfirmDialog
component.cc @fullofcaffeine @ciampo
Testing Instructions
Checklist:
*.native.js
files for terms that need renaming or removal).