Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Update npm packages to remove warnings from the console #3908

Merged
merged 3 commits into from
Dec 12, 2017

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Dec 11, 2017

Description

Fixes #3107. This PR updates a few npm packages to get rid of npm warnings:

npm WARN babel-loader@6.4.1 requires a peer of webpack@1 || 2 || ^2.1.0-beta || ^2.2.0-rc but none is installed. You must install peer dependencies yourself.
npm WARN react-autosize-textarea@0.4.8 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-autosize-textarea@0.4.8 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-datepicker@0.46.0 requires a peer of react-dom@^0.14.0 || ^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-slot-fill@1.0.1 requires a peer of react@^15.5.8 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react@^15.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN react-transition-group@1.2.0 requires a peer of react-dom@^15.0.0 but none is installed. You must install peer dependencies yourself.

There is still one warning logged on the console:

npm WARN ajv-keywords@2.1.0 requires a peer of ajv@>=5.0.0 but none is installed. You must install peer dependencies yourself.

It comes from the enzyme package which I updated to the latest version. I would wait until it's resolved on the enzyme side.

It also fixes new lint option for Jest:

30:27 warning Use toHaveLength() instead jest/prefer-to-have-length

How Has This Been Tested?

npm test & npm dev still work.

Tested manually in the browser.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@gziolo gziolo self-assigned this Dec 11, 2017
@@ -40,14 +40,13 @@ describe( 'BlockIcon', () => {
} );

it( 'renders a component', () => {
class MyComponent extends Component {
Copy link
Member Author

@gziolo gziolo Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint had some issues with having this inlined ...

45:5 error Your render method should have return statement react/require-render-return

"react-redux": "5.0.6",
"react-transition-group": "1.2.0",
Copy link
Member Author

@gziolo gziolo Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is no longer used. I removed it.

@gziolo gziolo changed the title Update/npm packages warnings Framework: Update npm packages to remove warnings from the console Dec 11, 2017
@gziolo gziolo added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Enhancement A suggestion for improvement. labels Dec 11, 2017
"babel-plugin-lodash": "3.2.11",
"babel-plugin-transform-object-rest-spread": "6.26.0",
"babel-plugin-transform-react-jsx": "6.24.1",
"babel-plugin-transform-runtime": "6.23.0",
"babel-preset-env": "1.6.0",
"babel-traverse": "6.26.0",
"check-node-version": "3.1.1",
"codecov": "2.3.0",
"codecov": "3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still using this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we display badge in Readme based on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framework: Update dependencies to match the latest version of React
4 participants