Divider: Improve default behavior when in vertical orientation #39316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #38842
What?
inline
element when theorientation
isvertical
.Why?
This ensures that the divider is visible "as expected" in both orientations when inside a flow layout container (not flex). Initially I was only going to improve the docs to demonstrate proper usage in the flex layout case, but I realized that we can also add a conditional
display
declaration so it just works out of the box.I'm inclined to classify this as a non-breaking change, because any proper usage of the vertical divider should already be
display: inline
or inside a flex container (in which case theinline
won't matter).Testing Instructions
npm run storybook:dev
and check out the stories forDivider
.vertical
orientation works without a flex container.stretch
aligned.