[RNMobile] Audio and File block test click delay on iOS too #39381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
added
the
Mobile App - Automation
|
Size Change: +57 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
hypest
changed the title
fluiddot
reviewed
Mar 14, 2022
packages/react-native-editor/__device-tests__/gutenberg-editor-audio.test.js
Outdated
Show resolved
Hide resolved
fluiddot
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
LGTM 🎊 ! I checked the E2E tests for Audio and File blocks locally, and both passed 🟢 .
As a side note, while testing the E2E tests, I found one of the potential causes of the random failures we often experience in GB-mobile repository. In both tests of Audio and File blocks, looks like the second test case relies on the results of the first one, specifically, it tries to query a block added in the previous test. Since Jest doesn't guarantee that test cases are run in order, it's not recommended to follow this practice. Each test case should be run isolated from the rest and should work.
Ah, good point. I wasn't going to deal with this in this PR but we might as well do it. WDYT about consolidating the 2 tests into one? Not ideal to have a test do more things but, I feel like for a UI test it's not that bad (unless the test becomes more flaky). EDIT: we discussed it in Slack and it's fine to go ahead with consolidating. |
fluiddot
approved these changes
Mar 17, 2022
packages/react-native-editor/__device-tests__/gutenberg-editor-file-@canary.test.js
Outdated
Show resolved
Hide resolved
packages/react-native-editor/__device-tests__/gutenberg-editor-audio.test.js
Outdated
Show resolved
Hide resolved
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
…s#39381) * Audio block click delay on iOS too * Same treatment to the file block * Introduce a waitForMediaLibrary tests helper * Use waitForMediaLibrary in audio and file tests * Consolidate the 2 audio tests into 1 * Consolidate the 2 file tests into 1 * Add some inline comments on the audio, file tests * More accurate test description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates a native mobile UI test to wait a bit longer on iOS for the media picker popup to appear.
Related PRs
Why?
Looks like the audio block test can be flaky and judging from the video of the failed test, the media picker popup (that harbors the "WordPress Media Library" option under test) can take a while to appear.
While developing this PR, the similar File block test failed so, this PR applies the same treatment to that test well.
How?
This PR brings the delay up to the 5secs from 1sec, matching the one for Android.
Testing Instructions
No particular test instructions. UI tests should be green still.