-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @juanmaguitar as codeowners of gutenberg docs #39453
Conversation
.github/CODEOWNERS
Outdated
@@ -1,5 +1,5 @@ | |||
# Documentation | |||
/docs @ajitbohra @mkaz @ryanwelcher | |||
/docs @ajitbohra @mkaz @ryanwelcher @juanmaguitar @mburridge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causing an error in the file:
Unknown owner on line 2: make sure @mburridge exists and has write access to the repository
@ocean90 I've removed @mburridge from this PR to unblock it. We will create another PR to add @mburridge to this list so we can deal with this issue apart |
It looks like I need to be added to the Gutenberg team. How do I request that? |
No, I don't think this is the final solution. But I think the best approach here is to create a separate PR to add your name to the CODEOWNERS so we can have a separated conversation to solve the issue that is causing this error
TBH, I don't know what's the cause of this error or the type of permissions we should have but I think It's best to deal with that in a separated PR. Can you create it to move this conversation there? |
I've requested membership of the Gutenberg team. I'll create a new PR once I've been granted membership. |
Awesome. Thanks @mburridge |
Adding @juanmaguitar as codeowners of gutenberg docs