Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @juanmaguitar as codeowners of gutenberg docs #39453

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

juanmaguitar
Copy link
Contributor

@juanmaguitar juanmaguitar commented Mar 15, 2022

Adding @juanmaguitar as codeowners of gutenberg docs

@@ -1,5 +1,5 @@
# Documentation
/docs @ajitbohra @mkaz @ryanwelcher
/docs @ajitbohra @mkaz @ryanwelcher @juanmaguitar @mburridge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causing an error in the file:

Unknown owner on line 2: make sure @mburridge exists and has write access to the repository

@juanmaguitar juanmaguitar changed the title Add @juanmaguitar @mburridge as codeowners of gutenberg docs Add @juanmaguitar as codeowners of gutenberg docs Mar 15, 2022
@juanmaguitar
Copy link
Contributor Author

@ocean90 I've removed @mburridge from this PR to unblock it. We will create another PR to add @mburridge to this list so we can deal with this issue apart

@juanmaguitar juanmaguitar requested a review from ocean90 March 15, 2022 10:13
@mburridge
Copy link
Contributor

It looks like I need to be added to the Gutenberg team. How do I request that?

@juanmaguitar
Copy link
Contributor Author

is removing me the solution?

No, I don't think this is the final solution. But I think the best approach here is to create a separate PR to add your name to the CODEOWNERS so we can have a separated conversation to solve the issue that is causing this error

Do I need to be granted permissions on this repo?

TBH, I don't know what's the cause of this error or the type of permissions we should have but I think It's best to deal with that in a separated PR. Can you create it to move this conversation there?

@mburridge
Copy link
Contributor

I've requested membership of the Gutenberg team. I'll create a new PR once I've been granted membership.

@juanmaguitar
Copy link
Contributor Author

juanmaguitar commented Mar 15, 2022

I've requested membership of the Gutenberg team. I'll create a new PR once I've been granted membership.

Awesome. Thanks @mburridge

@cbravobernal cbravobernal merged commit 6f7af74 into WordPress:trunk Mar 15, 2022
@github-actions github-actions bot added this to the Gutenberg 12.9 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants