Migrate a11y test to Playwright #39638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
kevin940726
force-pushed
the
add/playwright-new-post
branch
from
fb58524
to
a5e5359
Compare
|
@kevin940726 changing the keyboard shortcut from I think that's what the |
JustinyAhin
added
the
[Type] Automated Testing
kevin940726
force-pushed
the
add/playwright-new-post
branch
from
a5e5359
to
bf2cc63
Compare
|
Should we close this in favor of #46038? The new PR will run a11y tests with multiple browsers. |
@Mamaduka Sorry for the confusion, I wasn't aware of this PR. I'd vote in favor of #46038, also because this PR is a bit stale. For example, some utils have already been merged into trunk e.g. |
|
@afercia, I agree that the tests in the new PR (after issues are fixed) will give us better coverage. Also, role-based locators are always preferred, and we're trying to include this in migrations whenever possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Migrate
a11y.test.jsto its Playwright version.Why?
See #38570 for its background and rationale.
How?
See MIGRATION.md for migration steps.
Testing Instructions
Run
npm run test-e2e:playwright -- /test/e2e/specs/editor/various/a11y.spec.js.