Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListView: fix e2e flakiness #39742

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

delowardev
Copy link
Contributor

@delowardev delowardev commented Mar 25, 2022

What?

ListView e2e test is being flagged as flaky

Why?

Fixes: #39506
Fixes: #39641

How?

Wait for the expect promise to be resolved.

Testing Instructions

Run packages/e2e-tests/specs/editor/various/list-view.test.js a few times, you will see it fails sometimes.

Screenshots or screencast

@delowardev delowardev changed the title ListView: reduce e2e flakiness ListView: fix e2e flakiness Mar 25, 2022
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thank you, @delowardev.

@Mamaduka Mamaduka merged commit 117509d into WordPress:trunk Mar 25, 2022
@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants