Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme JSON: use block global style for block gap where no gap value exists in layout.php #39870

Closed

Commits on May 16, 2022

  1. In the theme JSON class, only skip top-level style properties when co…

    …mpiling the styles.
    
    In layout.php, if there is no block-level value for blockGap, but a global styles value available for blockGap, use the latter.
    ramonjd committed May 16, 2022
    Configuration menu
    Copy the full SHA
    2bf7d9b View commit details
    Browse the repository at this point in the history
  2. In the theme JSON class, linting

    In layout.php, move check for global style into gutenberg_render_layout_support_flag
    ramonjd committed May 16, 2022
    Configuration menu
    Copy the full SHA
    b703a73 View commit details
    Browse the repository at this point in the history
  3. Updated tests to reflect the changed situation:

    - Before we were unsetting blockGap for block and elements from the merged $theme_json structure in sanitize().
    - After we keep them in the merged $theme_json, but skip them when printing out the global stylesheet.
    ramonjd committed May 16, 2022
    Configuration menu
    Copy the full SHA
    aac2cef View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Configuration menu
    Copy the full SHA
    88d1f54 View commit details
    Browse the repository at this point in the history