Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto set first Navigation Menu as current if only 1 exists #39880

Merged
merged 18 commits into from
Apr 5, 2022
Merged

Auto set first Navigation Menu as current if only 1 exists #39880

merged 18 commits into from
Apr 5, 2022

Commits on Apr 4, 2022

  1. Auto set first Menu if exists

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    23c7c63 View commit details
    Browse the repository at this point in the history

  2. Allow for user to explicitly create a new fully empty Menu

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    51b32e2 View commit details
    Browse the repository at this point in the history

  3. Make code more self documenting

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    13881df View commit details
    Browse the repository at this point in the history

  4. Avoid flash of Placeholder

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    6704423 View commit details
    Browse the repository at this point in the history

  5. Add test for auto selecting first Nav 

    Currently broken
    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    2ecc26a View commit details
    Browse the repository at this point in the history

  6. Add tests to cover auto selection of first Menus

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    1232b07 View commit details
    Browse the repository at this point in the history

  7. Fix test issues

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    5104ac2 View commit details
    Browse the repository at this point in the history

  8. Fix permissions test to account for auto selection

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    5edb90c View commit details
    Browse the repository at this point in the history

  9. Amend comment 

    Addresses #39880 (comment)
    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    1fdbb2d View commit details
    Browse the repository at this point in the history

  10. Avoid var declaration 

    Addresses #39880 (comment)
    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    711e63d View commit details
    Browse the repository at this point in the history

  11. Avoid relying on promise returned from data actions 

    Addresses #39880 (comment)
    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    e70648e View commit details
    Browse the repository at this point in the history

  12. Improve loading and placeholder conditionals around Nav Menus having … 

    …been loaded
    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    aa26d0c View commit details
    Browse the repository at this point in the history

  13. Restore comment

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    6ef8ad8 View commit details
    Browse the repository at this point in the history

  14. Fix loading state test

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    defb8b6 View commit details
    Browse the repository at this point in the history

  15. Avoid ref and relying on existing state 

    Kudos to @adamziel #39880 (comment)
    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    c15dd88 View commit details
    Browse the repository at this point in the history

  16. Remove duplicate e2e util

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7e4e0f6 View commit details
    Browse the repository at this point in the history

  17. Simplify by reverting additional handler function

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    03718a5 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Fix test spellings 

    Co-authored-by: Andrei Draganescu <me@andreidraganescu.info>
    @getdave @draganescu
    getdave and draganescu authored Apr 5, 2022
    Configuration menu
    Copy the full SHA
    f86eb19 View commit details
    Browse the repository at this point in the history