[Mobile] - Quote - Use nested blocks #39974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ella van Durpe <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Dennis Snell <dennis.snell@automattic.com> Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
geriux
added
[Status] In Progress
geriux
force-pushed
the
update/quote-to-nested-native
branch
from
66b5202 to
552ec71
Compare
geriux
changed the title
|
Size Change: +26 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
added 9 commits
April 1, 2022 15:10
… get the first element which is the main list
…erit from the parent.
geriux
added
Mobile App - Automation
jhnstn
reviewed
Apr 1, 2022
Oh that's the left border that's applied to the Quote block. If a text color is applied to the block, the left border would use the color as well like: Without a text color set the line is black: If you select a text color: Thanks for testing it out! |
Thanks for clearing that up @geriux ! |
oandregal
force-pushed
the
update/quote-to-nested
branch
from
c8be7aa to
a5087b7
Compare
oandregal
force-pushed
the
update/quote-to-nested
branch
from
a5087b7 to
7c5222f
Compare
|
Closing in favor of #40439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #25892
Gutenberg mobile PR-> [Mobile] - Quote - Use nested blocks wordpress-mobile/gutenberg-mobile#4725What?
This PR adds compatibility to the new format of the Quote block on mobile.
Why?
To stay up to date with core changes and prevent invalid content or other possible issues.
How?
It changes the shared code by adding a missing text alignment needed in mobile as well as the style prop to be able to render colors.
Adds a new feature in the Paragraph block to inherit the parent's alignment if there's any set.
Within
BlockQuotationremoves some unneeded code that was used in the previous quote format. As well as setting the styles in the container. It also updates the style paddings to take into account inner blocks.Testing Instructions
Screenshots or screencast
Quote block with inner blocks
Quote block with text and background colors.
Quote block with alignment set
Quote block with another kind of inner block e.g. Image