Post Template: Add missing 'wp-block-post' class in the editor #40010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +557 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
andrewserong
reviewed
Apr 4, 2022
There was a problem hiding this comment.
Thanks for the ping @Mamaduka, and for picking up this issue!
This is working for the post template preview within the editor, but once one of the instances of the post template is selected, it uses the PostTemplateInnerBlocks component instead of the preview, so I think we might need to add a similar line around line 29 of the same file to handle that component? Here's the markup I'm seeing in the editor:
|
Good catch, @andrewserong. I will update code shortly. |
|
@andrewserong added missing class name in 386710d. |
andrewserong
approved these changes
Apr 5, 2022
|
Thanks for testing and review, @andrewserong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #39991.
PR adds missing class to the Post Template’s post markup in Site Editor.
Testing Instructions