Mark/data apis unstable #40028
Merged
Mark/data apis unstable #40028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
youknowriad
force-pushed
the
mark/data-apis-unstable
branch
from
0cc7327
to
a210acb
Compare
|
Size Change: -8 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #39977
What?
We have some internal APIs in the data package that are being used by useSelect to track and subscribe to a subset of stores from a data registry. This PRs marks this APIs as unstable instead of experimental
Why?
I think these API are never meant to be used by third-party developers, it's more of an implementation detail for useSelect. So it makes sense to mark these APIs as "internal". That said we don't have a guideline for "internal" API yet but
__unstableis what gets the closest right now. It's better then experimental because experimental APIs are potential future stable APIs but unstable are not. See guidelines.Testing Instructions
Nothing to test really, CI should cover everything here.