CustomSelectControl: Make chevron consistent with SelectControl #40049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.26 kB (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
jasmussen
reviewed
Apr 6, 2022
|
Nice, these little patches all add up, thanks a ton. This one seems good to land per a quick code review. |
This reverts commit d42f575.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39400
What?
Makes the
chevronDownicon of the CustomSelectControl component match the size and spacings of the one in SelectControl.Why?
For visual consistency between SelectControl and CustomSelectControl.
How?
Make
Iconsize the same as SelectControl, and adjust the righthand spacing.Testing Instructions
npm run storybook:devSelectControlto see a temporary comparison of SelectControl, CustomSelectControl, and the new 36px height CustomSelectControl.Any optical adjustments we'd like to make?
Screenshots or screencast
⭐ Reminder: The 36px height one is the most important variant moving forward. The 30px variants will be deprecated.