MultiSelectSidebar: Fix spacing of color panel items #40071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
aaronrobertshaw
approved these changes
Apr 6, 2022
|
Size Change: -1 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Apr 6, 2022
Procorners
approved these changes
Apr 6, 2022
Procorners
approved these changes
Apr 6, 2022
Procorners
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #40040
What?
While testing #40036 it was reported that spacing of the color panel items in the multi-select inspector was off. It looks like following #34027 we needed to add the class name to the slot at the multi-select level, too, to remove the spacing between items.
Why?
Fixes the additional spacing between color items (like Background and Text) in the multi select sidebar, as reported in #40040
How?
Add the same classname used in the individual sidebar for the color slot that gets rendered for the multi select sidebar (this class removes the row gap between items).
Testing Instructions
Screenshots or screencast