Post Comments Form: Allow to add it to the Site Editor #40108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Block] Post Comments Form
|
Size Change: +20 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
cbravobernal
requested review from
SantosGuillamot,
michalczaplinski,
ockham,
Copons and
DAreRodz
michalczaplinski
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Looks good to me! 👍
By the way, I think this is fixing #37182
SantosGuillamot
approved these changes
Apr 7, 2022
Yes. Similar to Post Content, Post Author, etc. |
Nice catch! |
cbravobernal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #37182.
Allow Post Comments Form to be added in FSE (Editor)
Why?
If we land the Comments Query blocks, we should have the form to add comments included in the same template.
Right now, when you add the block in the site editor you get this message:
This happens because of this check, which shows the same error message if the comments are disabled on a
postorpage:When we are in the site editor, both
postTypeandpostIdvariables areundefinedso this check will show us both errors.The frontend instead is loading the form in a correct way.
How?
By including the possibility of being inside the editor (
postTypeorpostIdvariables areundefined).In that case, we show the default
post comments formplaceholder.Testing Instructions
Before the PR:
After the PR: