Column Block: Add blockGap support. #40122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Great idea @ndiego! This is testing well for me, and makes good sense to add it in now that the block is using the layout support 👍
Also, since the block spacing control is hidden by default, I don't think there's too much concern about folks being confused between this block spacing control and the Columns level control, since you sort of have to go looking for it anyway.
LGTM!
|
Thanks for reviewing @andrewserong! As soon as the checks finish running, I'll 🚢 |
carolinan
approved these changes
Apr 7, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR simply adds blockGap support to Column blocks.
Why?
#39422 enabled layout on Column blocks. As a result, all blocks within a Column block now have blockGap applied. While this is fine, I think we should go the extra step end ensure that blockGap control is then enabled for the Column block. Since #39422 will be included with WordPress 6.0, I feel we should try and get this PR included as well with Gutenberg 13.0.
I know we are close to the deadline but just caught this in my testing. 😬
Testing Instructions