Components: add TypeScript refactor guidelines #40153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Developer Documentation
|
@mirka I've added my initial notes, even if they are definitely a bit rough and incomplete. We can use this PR to collaborate / add our own insights ! |
mirka
reviewed
Apr 8, 2022
Co-authored-by: Lena Morita <lena@jaguchi.com>
Co-authored-by: Lena Morita <lena@jaguchi.com>
|
All feedback has been addressed (only this comment still potentially pending). @mirka, do you think we should still refine / add anything to these guidelines for now? Otherwise we could go ahead, merge them and open new, small PRs every time we feel like making any improvements in the future |
mirka
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add first version of the guidelines for refactoring components to TypeScript (see #35744 for more details).
Why?
Have a standardized way of approaching the refactor, make it easier for folks to contribute.
Testing Instructions
Read the newly added docs (no runtime changes).