Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing class-wp-style-engine-gutenberg.php in the plugin build #40191

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented Apr 8, 2022

What?

Updates plugin ZIP creation to include the missing class-wp-style-engine-gutenberg.php files.

Fixes the Gutenberg 13.0.0 RC1 that lacks this file and causes the following error:

Fatal error: Uncaught Error: Class 'WP_Style_Engine_Gutenberg' not found in wp-content/plugins/gutenberg/lib/block-supports/spacing.php:55 

Related PRs:

cc @ramonjd @andrewserong @Mamaduka who worked on the original PRs

@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality labels Apr 8, 2022
@adamziel adamziel requested a review from gziolo April 8, 2022 15:38
bin/build-plugin-zip.sh Outdated Show resolved Hide resolved
Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
@adamziel adamziel merged commit c151c0c into trunk Apr 8, 2022
@adamziel adamziel deleted the update/add-class-wp-style-engine-gutenberg-to-build branch April 8, 2022 15:50
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 8, 2022
adamziel added a commit that referenced this pull request Apr 8, 2022
…ld (#40191)

* Add the missing class-wp-style-engine-gutenberg.php in the plugin build

* Update bin/build-plugin-zip.sh

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>

Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
@ramonjd
Copy link
Member

ramonjd commented Apr 8, 2022

Oh dang, thanks for catching and fixing this. I totally missed it. 🙇

@andrewserong
Copy link
Contributor

Thanks for catching this, Adam! 🙇 I tested npm run build during the review phase, but completely forgot to look at the build script for the plugin .zip — great to know for next time 🙂

@priethor priethor added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants