Plugin: Fix REST API class redeclaration #40265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
Gutenberg Plugin
Mamaduka
approved these changes
Apr 12, 2022
ntsekouras
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Looks good, thanks @gziolo ! Let's wait for the CI first before landing though 😄
|
The performance tests job failed, but I belive it's because we run it against |
gziolo
added a commit
that referenced
this pull request
Apr 12, 2022
|
Cherry-picked this PR to the Gutenberg 13.0 plugin release to ensure it can be tested with the latest version of WordPress core. |
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When testing the Gutenberg plugin with the most recent version of WordPres core it throws fatal error after: WordPress/wordpress-develop@a807e86.
Why?
2 new classes weren't correctly guarded against redeclaration.
How?
Correctly check whether classes just added to WordPress core are already declared.
Testing Instructions
All CI checks should pass again.