[RNMobile] Display 'expanded' inserter when title is selected #40341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
changed the title
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
SiobhyB
added
Mobile App - i.e. Android or iOS
SiobhyB
added
the
[Feature] Inserter
|
Thanks for this fix @SiobhyB ! I will jump right in to review.
cc @iamthomasbishop for the visibility as this is a departure from the original design, but I think it makes sense as a fix to ship the basic functionality of this feature. |
hypest
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
LGTM Siobhan!
I tested:
- Creating a new post and observe if visual glitch: No glitch, expanded button remains expanded ✅
- Focus on the empty paragraph block in a new post: expended button contracts ✅
- Focus back to the title: contracted button expands ✅
- Typing some text in the title: button remains expanded ✅
- Typing some text in the empty paragraph block: button contracts ✅
- Opening and closing the Inserter while paragraph is focused and has some text: button stays contracted, no glitch ✅
- Opening and closing the Inserter while paragraph is empty and focused: button stays contracted, no glitch ✅
- Removing focus from the paragaph/title (by collapsing the virtual keyboard): button expands, no glitch ✅
- Opening and closing the Inserter while nothing is focused: button stays expanded, no glitch ✅
Let's wait for the gutenberg-mobile side PR to get fully green as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobile:[RNMobile] Display 'expanded' inserter when title is selected wordpress-mobile/gutenberg-mobile#4757What?
An "expanded" style was applied to the block inserter and toolbar in #39726. This new style was only visible when the block or title was de-selected in the post editor. With this PR, this is updated so that the new style does display when the title is selected.
Why?
As per the following screencast, you'll see that a flash of the new "expanded" button style was displaying when first opening a post:
newpost.mov
This was happening because there is a delay of a few seconds before the title of a new post becomes selected, which caused the jump in styling.
As this is a bit off-putting, especially for users who are just creating a post for the first time, we're preventing the flash by always displaying the "expanded" button style when the title is selected in the editor.
In the future, we may change this behaviour so that the new style only displays when first opening the post editor. We're sticking to always displaying the style when a title is selected for now as we wanted to move quickly on a fix.
How?
All references to
isTitleSelectedhave been removed from the logic around displaying the new style.Testing Instructions
To verify this fix, follow these steps within the WordPress Android or iOS app:
Screenshots or screencast