-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eslint: add TypeScript tests and stories to development files #40504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
changed the title
Eslintrc: add TypeScript tests and stories to development files
Eslint: add TypeScript tests and stories to development files
Apr 21, 2022
ciampo
added
[Type] Enhancement
A suggestion for improvement.
[Type] Build Tooling
Issues or PRs related to build tooling
labels
Apr 21, 2022
gziolo
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, makes sense. We should update it long time ago 😄
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
kevin940726
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🧡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Tweak ESLint's config to include TypeScript unit tests and Storybook stories in the list of development files.
Why?
This is change is needed to support the usage of TypeScript across the repo (especially in certain packages, like
@wordpress/components
)This PR is a follow-up to #39436 , taking inspiration from @kevin940726 's changes to
.eslintrc
initially proposed in #40253How?
Using the
[tj]s?(x)
glob matching pattern to include thejs
,jsx
,ts
, andtsx
file extensions in the patterns matching tests and stories.Testing Instructions