Post Comments block: Fix missing label in placeholder #40527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Type] Bug
|
Size Change: +27 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ryelle
reviewed
Apr 21, 2022
luisherranz
changed the title
DAreRodz
approved these changes
Apr 22, 2022
13 tasks
ndiego
added
the
Backport to WP 6.7 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
Apr 25, 2022
|
Cherry-picked to the |
gziolo
removed
the
Backport to WP 6.7 Beta/RC
priethor
added
[Focus] Accessibility (a11y)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix missing label for textarea in Post Comments block placeholder.
Why?
@ryelle did an a11y review of the new placeholder and discovered that the label of the textarea is missing.
How?
The label tag is actually there, but I removed the textarea id because the linter was complaining.
I added it back along with an eslint exception.As per @ryelle suggestion (#40527 (comment)), I switched to using
useInstanceIdinstead.Testing Instructions
inserterproperty of the Post Commentsblock.jsontotrueso the block shows up in the inserter, or switch to the Code Editor and paste<!-- wp:post-comments /-->.